Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Resolve RedirectVersionBanner malfunction #321

Merged

Conversation

hyeongrok7874
Copy link
Contributor

Issue

Currently, when trying to navigate to the latest version documentation via RedirectVersionBanner, users are incorrectly redirected to the library root page of the current version instead

Changes

  • Added to prop in RedirectVersionBanner's Link component for latest version navigation
  • Fixed by passing a fullPath (with routeId) from the latest match, though there might be a better solution given my limited familiarity with tanstack/query.

Related Issue

#310

…current version root page instead of the latest version
Copy link

netlify bot commented Dec 20, 2024

Deploy Preview for tanstack ready!

Name Link
🔨 Latest commit 02ca327
🔍 Latest deploy log https://app.netlify.com/sites/tanstack/deploys/6765a383c0f1000008b8e4fd
😎 Deploy Preview https://deploy-preview-321--tanstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 47 (🔴 down 22 from production)
Accessibility: 96 (🟢 up 1 from production)
Best Practices: 83 (🔴 down 9 from production)
SEO: 84 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@tannerlinsley tannerlinsley merged commit 9dbcaff into TanStack:main Dec 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants